Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 forceload vector now requires an Integer #699

Merged
merged 5 commits into from
Sep 28, 2020
Merged

🐛 forceload vector now requires an Integer #699

merged 5 commits into from
Sep 28, 2020

Conversation

ChenCMD
Copy link
Member

@ChenCMD ChenCMD commented Sep 26, 2020

Fix #698

@ChenCMD ChenCMD marked this pull request as draft September 27, 2020 09:12
@ChenCMD
🐛 So as not to operate at relative vectors
8b9795e 
because false warnings can occur
@ChenCMD ChenCMD marked this pull request as ready for review September 28, 2020 06:00
SPGoding
SPGoding reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@SPGoding SPGoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Btw after this PR you can create new branches in this repository directly instead of using your fork, and you can push to the master branch without creating a PR when you feel confident ;D

src/data/CommandTree1.16.ts Outdated Show resolved Hide resolved
src/nodes/VectorNode.ts Outdated Show resolved Hide resolved
src/nodes/VectorNode.ts Outdated Show resolved Hide resolved
@ChenCMD
Copy link
Member Author

ChenCMD commented Sep 28, 2020

Btw after this PR you can create new branches in this repository directly instead of using your fork, and you can push to the master branch without creating a PR when you feel confident ;D

From now on, I will create a branch directly and work on it, but I will do it with PR for a while. I'm not so confident so lol

@SPGoding SPGoding merged commit cf530fd into SpyglassMC:master Sep 28, 2020
@ChenCMD ChenCMD deleted the patch/forceload branch September 28, 2020 16:04
@SPGoding
Copy link
Member

SPGoding commented Oct 2, 2020

🎉 This PR is included in version 3.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SPGoding SPGoding added the *released The changes has been released label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPGoding SPGoding SPGoding approved these changes

Assignees
No one assigned
Labels
*released The changes has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vector of forceload requires an integer
2 participants
@ChenCMD @SPGoding