Skip to content

๐Ÿ”€ :: (#104) Mission Loading Screen #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

yeongun130
Copy link
Contributor

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฌธ์ œ ๋ฆฌ์ŠคํŠธ, ์ฑ„์ ํ•  ๋ฌธ์ œ ๋ฆฌ์ŠคํŠธ์˜ ๋กœ๋”ฉ ์‹œ ํ™”๋ฉด์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋กœ๋”ฉ ํ™”๋ฉด ์ถ”๊ฐ€

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

  • ์—†์Œ

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋А๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

  • ์ž˜๋ชป ๊ตฌํ˜„๋œ ๋ถ€๋ถ„์ด ์žˆ๊ฑฐ๋‚˜ ์ปจ๋ฒค์…˜์— ๋งž์ง€ ์•Š๋Š” ๋ถ€๋ถ„์ด ์žˆ๋‹ค๋ฉด ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊ฒจ์ฃผ์„ธ์š”

@@ -89,4 +89,5 @@ private fun EntireMissionScreen(
}
}
}
Log.e("testt", missionUiState.toString())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋กœ๊ทธ ์ง€์›Œ ์ฃผ์„ธ์š”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

613c768 ๋กœ๋”ฉ ํ™”๋ฉด ๋กœ์ง ๋ณ€๊ฒฝํ•˜๋ฉด์„œ ์ง€์› ์Šต๋‹ˆ๋‹ค. ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Comment on lines 74 to 75
getMissionUiState = missionUiState,
missionList = mission,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด ๋ถ€๋ถ„๋“ค ๋„ค์ด๋ฐ ํ†ต์ผํ•˜๋Š”๊ฒŒ ์–ด๋–จ๊นŒ์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

613c768 ๋ฐ‘์— ๋‚จ๊ฒจ์ฃผ์‹  ์ฝ”๋ฉ˜ํŠธ์™€ ๊ฐ™์ด ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

Comment on lines 42 to 69
when (getMissionUiState) {
is GetMissionUiState.Success -> {
LazyVerticalGrid(
modifier = Modifier
.fillMaxSize()
.background(color = colors.WHITE),
columns = GridCells.Fixed(2),
contentPadding = PaddingValues(
start = 16.dp,
top = 16.dp,
),
) {
itemsIndexed(missionList) { _, item ->

Box(
contentAlignment = Alignment.Center
) {
EntireMissionItem(
name = item.user.name,
title = item.title,
point = item.point,
onClick = { onClick(item.id) },
)
}

}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์™ธ๋ถ€์—์„œ ์„ฑ๊ณต์‹œ UiState๋ฅผ ์ฃผ์ž…ํ•˜๋Š” ๊ฑธ๋กœ ์•„๋Š”๋ฐ ๋‚ด๋ถ€์—์„œ๋„ ๋˜ when๋ฌธ์„ ๋Œ๋ฆฌ๋Š” ๊ฑด ๋ถˆํ•„์š” ํ•œ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค
์™ธ๋ถ€ ๋กœ์ง์„ ์ง€์šฐ๊ณ  ๋‚ด๋ถ€ ๋กœ์ง๋งŒ ์œ ์ง€ํ•˜๋Š”๊ฒŒ ์–ด๋–จ๊นŒ์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

613c768 ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

@yeongun130 yeongun130 merged commit 799a900 into develop Jul 10, 2024
1 check passed
@yeongun130 yeongun130 deleted the feature/104_mission_loading_screen branch July 10, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ฌธ์ œ ๋ฆฌ์ŠคํŠธ, ์ฑ„์ ํ•  ๋ฌธ์ œ ๋ฆฌ์ŠคํŠธ ๋กœ๋”ฉ ์‹œ ํ™”๋ฉด
3 participants