Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORKBUN: Add registrar support #2542

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 2, 2023

This PR adds support for using PORKBUN as a registrar, via their getNs and updateNs APIs.

@str4d str4d force-pushed the porkbun-registrar branch from 1465e5d to 28180e1 Compare September 6, 2023 23:12
@str4d
Copy link
Contributor Author

str4d commented Sep 6, 2023

Rebased on master and added support for the new NS fetching API that the Porkbun team just added in response to my ticket 🐷💖

@str4d str4d marked this pull request as ready for review September 6, 2023 23:17
Copy link
Contributor

@tlimoncelli tlimoncelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 2 minor suggestions.

providers/porkbun/api.go Outdated Show resolved Hide resolved
providers/porkbun/api.go Outdated Show resolved Hide resolved
@tlimoncelli tlimoncelli merged commit 255e08c into StackExchange:master Sep 14, 2023
2 checks passed
@str4d str4d deleted the porkbun-registrar branch September 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants