Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending change_files parameter which describes changed files in the updated commits #12

Merged

Conversation

userlocalhost
Copy link
Collaborator

This is the change for #11.

The main points of this change are following.

  • Appending new parameter changed_files which describes manipulated files within the updated commits for each operation type 'add', 'delete', 'moved', 'modified' to the dispaching payload.
    But currently this feature is workable only with the BitBucket Server. I should be able to implement equivalent feature for the BitBucket cloud.

  • Correcting the payload format which is written in the README. Previously, the only commits parameter value which is a parameter of dispatching payload was described in the README. Then, I corrected it to describe whole payload format and added new parameters changed_files and files.
    The files is the parameter which describes manipulated files in the target commit. And changed_files means the all manipulated files within the whole updated commits by omitting the overlapping.

Thank you.

@Kami
Copy link
Contributor

Kami commented Sep 29, 2017

Nice work - thanks.

Will have a look shortly.

README.md Outdated
"time": "'2017-06-24 08:17:26'"
}
]
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the trigger format hasn't changed and it's not backward compatible, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at the code changes below it looks like it didn't really change, just a new key was added and readme was out of date.

@Kami
Copy link
Contributor

Kami commented Sep 29, 2017

Build appears to be failing (lint issue), besides that, LGTM 👍

@userlocalhost
Copy link
Collaborator Author

Thank you for your review and pointing it out!

Below the payload parameter of trigger format was omitted in the repository_sensor.yaml. And the payload parameter which is described in the README was different with the implementation, as you mentioned.

I specified the trigger format in detail and corrected the README description for up to date.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants