Add redis to install scripts #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The coordinator service is required in most cases for running workflows. Install redis-server and configure redis as the default coordinator backend used by tooz. This will avoid a number of workflow issues, especially for new StackStorm users.
|
This PR pairs with StackStorm/st2#5226. |
|
As @armab said, LGTM, just need to make sure we update all other affected places (sadly there are quite a lot of those and some of those we will only stumble upon in the future - e.g. st2web also uses docker compose setup for end to end tests, etc.). |
This was referenced Apr 30, 2021
arm4b
approved these changes
May 9, 2021
There was a problem hiding this comment.
Looks great with updating it in all the places! 👍
Additional thanks for adding CircleCI smoke tests here to run Redis in Docker.
We'll also need for stackstorm/st2 to add the default Redis [coordination] string in the default st2.conf:
https://github.com/StackStorm/st2/blob/master/conf/st2.package.conf similar to other backends like Mongo and RabbitMQ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coordinator service is required in most cases for running workflows. Install redis-server and configure redis as the default coordinator backend used by tooz. This will avoid a number of workflow issues, especially for new StackStorm users.