-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fixate-requirements.py to cope with PIP 20.3.3 #5123
Conversation
Need to resolve problem seen when try and building this version of ST2 using the dockerfiles from StackStorm/st2packaging-dockerfiles#97:
|
Looks like if you upgrade the version of pip used when you do the build that it has a different way of determining dependencies, and it goes back through lots of old versions - if it gets to versions that aren't python3 compatible then it fails. So have to then fixate those requirements so the min is at least a py3 version. |
…e to use ipaddress built-in python3 module
The build takes much longer with this pip, will need to probably update the version requirements to much higher ones to enable it to have less versions to compare when it works out its dependencies. |
…lled in by other dependencies
…lled in by other dependencies
…lled in by other dependencies
…lled in by other dependencies
…lled in by other dependencies
…/st2 into amanda_tmp_virtualenv
We just reformatted the code with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comment suggestions. The code looks great.
CI failures are resolved on master. Merging should resolve them. |
Co-authored-by: Jacob Floyd <cognifloyd@gmail.com>
Weird. I wonder why GHA didn't check the last commit. |
Related change is merged, but waiting for dockerfiles to be published: StackStorm/st2packaging-dockerfiles#98 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks a lot for diving deep here!
Building upon #5060. Updates to fixate-requirements.py to see if can use newer version of pip for make requirements.