replacing netlify deployment with S3 deployment #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dev successful
|
@flaxel this custom widget workflow is a candidate for the reusable workflows. |
flaxel
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Could we also remove the netlify.toml file? What is the difference between S3-deployment-action and deploy-web-assets?
| @@ -0,0 +1,120 @@ | |||
| name: Deploy to AWS S3 | |||
There was a problem hiding this comment.
Could we name the file cd? 🤔
There was a problem hiding this comment.
I found it more intuitive, since it directly states where it is deployed to
m-seidel
commented
Sep 27, 2022
Co-authored-by: Falk Puschner <falk.puschner@arcor.de>
Ninerian
approved these changes
Nov 14, 2022
nd type. Renamed file to match other files
Ninerian
force-pushed
the
NFS-add_S3_deployment
branch
from
dc708fc to
bfd452d
Compare
m-seidel
added
dev
github-actions
bot
added
the
dev successful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Checklist