Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface for calling svZeroDPlus from other codes #20

Merged
merged 47 commits into from
Jan 24, 2023
Merged

Interface for calling svZeroDPlus from other codes #20

merged 47 commits into from
Jan 24, 2023

Conversation

menon-karthik
Copy link
Member

@menon-karthik menon-karthik commented Dec 27, 2022 •
edited
Loading

Karthik Menon and others added 30 commits September 21, 2022 17:50
Modified CMakeList files - main and interface
5bfc201
Changed solver_time_Step_ to external_time_step_
286f7cd
Changed model to pointer in configreader
23f3669
Updated interface to reflect latest code svzerod structure
283f01d
Fixed bug in external time
f76828b
Added run_simulation. Working
c9242d2
Renamed update_model_dependent_params to set_model_dependent_params
a1b2f17
Added model->block_index_map
0786166
Added update_block_params
07ce0d8
Update params seems to be working
5ac9320
Added get_block_params and block_names list
8d69845
Some cleaning up
010759b
Return variable_names in initialize
2cdcfb5
Added initial condition to test and removed from set_ICs
41c2017
Changed block_name from char* to string in read/update_params
33b82d5
return numCycles and steps in initialize
e5169bf
Some cleaning up
381e073
Initial work adding external coupling blocks
dfe245d
Debugging external coupling blocks. Now reads all blocks correctly
950b81d
External coupling blocks and tests working. Need to clean up
3d2ad07
Added coupling_loc variable
cb0d50b
Saved coupling loc
29cfccb
Added external_coupling_blocks vector to model
ffe3f50
Error message for steady initial with closedLoppHeart
1a0c64d
Added get_block_node_id
8b0d25f
debugging print messages
60a86c6
Added semicolon to error msg
736b9ab
Some cleaning up
e7a98ca
Added handling external time step and coupled simulation
a4847c6
Added external coupling flag and isperiodic flag
d1ad4b1
Karthik Menon and others added 17 commits October 17, 2022 14:07
Added external coupling flag and isperiodic flag
901d3c5
Debugging and added interface->state update in run_simulation
e979548
Debugging. Now working for test cases and fortran external solver tes…
07fcd83 
…t case
Debugging. Added debug_msg
5e91bce
Cleaning up
81acb66
Comment print params
14e10f7
pressure_all and flow_all initial conditions
da9280f
P_c: initial condition
bd3af14
Cleaning up
8c75132
try catch block for update and read model params
9b1424f
Module required for clang format on sherlock
f5e647d
clang formatting
cdb5547
Added bloodvessel to external coupling block connected types
1fb58bd
@menon-karthik
merged with master and resolved conflicts in configreader, main.hpp, …
6039459 
…resistancebc.hpp
@menon-karthik
fixed pointer bug in configreader bloodvesseljunction
ef66424
updated clang documentation
23db4e1
clang formatting
0169165
@mrp089 mrp089 self-requested a review January 23, 2023 17:24
mrp089
mrp089 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Even with test cases :-)

@mrp089 mrp089 merged commit dde04dd into SimVascular:master Jan 24, 2023
@mrp089 mrp089 mentioned this pull request Jan 24, 2023
Closed
@menon-karthik menon-karthik deleted the interface_tuning branch February 17, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrp089 mrp089 mrp089 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menon-karthik @mrp089