-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix typo in StringLiteral toSQL caused by mixing single quotes within double quotes #13102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HangyuanLiu
force-pushed
the
fix-quote-view
branch
from
November 8, 2022 08:40
84cc687
to
55c5bf1
Compare
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 4 / 4 (100.00%) file detail
|
run starrocks_admit_test |
silverbullet233
approved these changes
Nov 8, 2022
Seaven
approved these changes
Nov 8, 2022
kangkaisen
approved these changes
Nov 8, 2022
murphyatwork
pushed a commit
to HangyuanLiu/starrocks
that referenced
this pull request
Nov 11, 2022
…es within double quotes (StarRocks#13102)
murphyatwork
pushed a commit
to HangyuanLiu/starrocks
that referenced
this pull request
Nov 11, 2022
…es within double quotes (StarRocks#13102)
murphyatwork
pushed a commit
to HangyuanLiu/starrocks
that referenced
this pull request
Nov 11, 2022
…es within double quotes (StarRocks#13102)
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 14, 2022
…es within double quotes (#13102)
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 14, 2022
…es within double quotes (#13102)
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 14, 2022
…es within double quotes (#13102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
Which issues of this PR fixes :
Fixes #13103
Problem Summary(Required) :
Checklist: