Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix typo in StringLiteral toSQL caused by mixing single quotes within double quotes #13102

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Nov 8, 2022

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Which issues of this PR fixes :

Fixes #13103

Problem Summary(Required) :

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr will affect users' behaviors
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wanpengfei-git
Copy link
Collaborator

[FE PR Coverage Check]

😍 pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/StringLiteral.java 4 4 100.00% []

@silverbullet233
Copy link
Contributor

run starrocks_admit_test

@kangkaisen kangkaisen merged commit 7450606 into StarRocks:main Nov 8, 2022
murphyatwork pushed a commit to HangyuanLiu/starrocks that referenced this pull request Nov 11, 2022
murphyatwork pushed a commit to HangyuanLiu/starrocks that referenced this pull request Nov 11, 2022
murphyatwork pushed a commit to HangyuanLiu/starrocks that referenced this pull request Nov 11, 2022
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2022
@HangyuanLiu HangyuanLiu deleted the fix-quote-view branch November 14, 2022 02:44
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2022
wanpengfei-git pushed a commit that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo error in StringLiteral toSQL caused by mixing single quotes within double quotes
5 participants