[BugFix] Keep update statement output column's type consistent with target table's columns #41969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
luohaha
previously approved these changes
Mar 1, 2024
Signed-off-by: shuming.li <ming.moriarty@gmail.com>
LiShuMing
force-pushed
the
fix/main/fix_update_column_type_incosistent
branch
from
1714d02
to
afd6fd5
Compare
kangkaisen
previously approved these changes
Mar 4, 2024
Seaven
reviewed
Mar 4, 2024
| Column column = targetTable.getColumn(colName); | ||
| Preconditions.checkState(column != null, "Column %s not found in table %s", colName, | ||
| targetTable.getName()); | ||
| if (!column.getType().matchesType(outputColumn.getType())) { |
There was a problem hiding this comment.
check the type can cast to target type？
There was a problem hiding this comment.
Add it. But this should not happen since it will fail in the analyzer phase.
packy92
reviewed
Mar 4, 2024
packy92
approved these changes
Mar 5, 2024
|
[FE Incremental Coverage Report]❌ fail : 27 / 36 (75.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Seaven
approved these changes
Mar 5, 2024
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
18 tasks
|
@mergify backport branch-3.1 |
✅ Backports have been created
|
18 tasks
caneGuy
pushed a commit
to caneGuy/starrocks
that referenced
this pull request
Mar 22, 2024
…ent with target table's columns (backport StarRocks#41969) (StarRocks#42187) Link: https://code.alibaba-inc.com/soe/starrocks/codereview/15895066
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
Mar 28, 2024
…ent with target table's columns (backport StarRocks#41969) (StarRocks#42115) Co-authored-by: shuming.li <ming.moriarty@gmail.com>
This was referenced Apr 11, 2024
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
Apr 22, 2024
…ent with target table's columns (backport StarRocks#41969) (StarRocks#42115) Co-authored-by: shuming.li <ming.moriarty@gmail.com>
wxl24life
pushed a commit
to wxl24life/starrocks
that referenced
this pull request
Apr 22, 2024
…ent with target table's columns (backport StarRocks#41969) (StarRocks#42187) Link: https://code.alibaba-inc.com/soe/starrocks/codereview/15895066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
castOutputColumnsTypeToTargetColumnsin LogicalPlan to OptExpression likeInsertPlanner.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: