Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix partition live number not update #49437

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[BugFix] Fix partition live number not update #49437

merged 1 commit into from
Aug 8, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented Aug 6, 2024 •
edited
Loading

Why I'm doing:

alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.

buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.

What I'm doing:

fix the update check.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb
[BugFix] Fix partition live number not update
803d85d 
Signed-off-by: wyb <wybb86@gmail.com>
@wyb wyb requested a review from a team as a code owner August 6, 2024 09:14
@mergify mergify bot assigned wyb Aug 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[FE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/TableProperty.java 4 4 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@alvin-celerdata alvin-celerdata merged commit 889a910 into StarRocks:main Aug 8, 2024
62 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Aug 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[BugFix] Fix partition live number not update (#49437)
557234a 
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.

buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.

What I'm doing:
fix the update check.

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 889a910)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/catalog/TableProperty.java
#	fe/fe-core/src/test/java/com/starrocks/catalog/TablePropertyTest.java
@mergify mergify bot mentioned this pull request Aug 8, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[BugFix] Fix partition live number not update (#49437)
b6e5220 
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.

buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.

What I'm doing:
fix the update check.

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 889a910)
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[BugFix] Fix partition live number not update (#49437)
0f5e083 
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.

buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.

What I'm doing:
fix the update check.

Signed-off-by: wyb <wybb86@gmail.com>
(cherry picked from commit 889a910)
This was referenced Aug 8, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[BugFix] Fix partition live number not update (backport #49437) (#49553)
18fde72 
Co-authored-by: wyb <wybb86@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[BugFix] Fix partition live number not update (backport #49437) (#49554)
950fbdf 
Co-authored-by: wyb <wybb86@gmail.com>
wyb added a commit to wyb/starrocks that referenced this pull request Aug 8, 2024
@wyb
[BugFix] Fix partition live number not update (StarRocks#49437)
4523817 
Why I'm doing:
alter table tbl set ("partition_live_number" = "2") can modify table partition live number,
but when FE restarts, partition_live_number will be recovered to old value.

buildPartitionLiveNumber checks the current value of partitionTTLNumber and does not update if it is not -1.

What I'm doing:
fix the update check.

Signed-off-by: wyb <wybb86@gmail.com>
@wyb wyb mentioned this pull request Aug 8, 2024
Merged
26 tasks
wyb added a commit that referenced this pull request Aug 8, 2024
@wyb
[BugFix] Fix partition live number not update (backport #49437) (#49583)
4b81c51 
Signed-off-by: wyb <wybb86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@wyb wyb

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyb @kevincai @alvin-celerdata