Setting the base_url flag of Jupyter images (kubeflow#2627)

* set base_url of jupyter * change the env base_url to NB_PREFIX to sync with kubeflow#2620
StatCan · Mar 6, 2019 · 7814ff3 · 7814ff3
1 parent b0ebef4
commit 7814ff3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/components/tensorflow-notebook-image/Dockerfile b/components/tensorflow-notebook-image/Dockerfile
@@ -19,6 +19,7 @@ ENV DEBIAN_FRONTEND noninteractive
 ENV NB_USER jovyan
 ENV NB_UID 1000
 ENV HOME /home/$NB_USER
+ENV NB_PREFIX /
 # We prefer to have a global conda install
 # to minimize the amount of content in $HOME
 ENV CONDA_DIR=/opt/conda
@@ -155,5 +156,5 @@ RUN docker-credential-gcr configure-docker && chown jovyan:users $HOME/.docker/c
 # Configure container startup
 EXPOSE 8888
 ENTRYPOINT ["tini", "--"]
-CMD ["sh","-c", "jupyter notebook --notebook-dir=/home/jovyan --ip=0.0.0.0 --no-browser --allow-root --port=8888 --NotebookApp.token='' --NotebookApp.password='' --NotebookApp.allow_origin='*'"]
+CMD ["sh","-c", "jupyter notebook --notebook-dir=/home/jovyan --ip=0.0.0.0 --no-browser --allow-root --port=8888 --NotebookApp.token='' --NotebookApp.password='' --NotebookApp.allow_origin='*' --NotebookApp.base_url=${NB_PREFIX}"]