-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport IDisposable ConfigProviders to 3.2 #1230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed: Placeholder configuration provider should dispose child providers * Fixed: ConfigServer configuration provider should dispose internal timer
TimHess
added
Component/Configuration
Issues related to Configuration providers
ReleaseLine/3.x
Identified as a feature/fix for the 3.x release line
labels
Dec 11, 2023
TimHess
changed the title
Backport IDisposable ConfigProviders
Backport IDisposable ConfigProviders to 3.2
Dec 11, 2023
TimHess
force-pushed
the
backport_1228
branch
3 times, most recently
from
December 11, 2023 23:09
64b3d49
to
ae3f0a5
Compare
/azp run Steeltoe.All |
Azure Pipelines successfully started running 1 pipeline(s). |
bart-vmware
requested changes
Dec 12, 2023
src/Configuration/src/ConfigServerBase/ConfigServerConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
src/Configuration/src/ConfigServerBase/ConfigServerConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
Azure Pipelines successfully started running 1 pipeline(s). |
TimHess
force-pushed
the
backport_1228
branch
2 times, most recently
from
December 12, 2023 16:13
b7d1ea5
to
74016f4
Compare
TimHess
force-pushed
the
backport_1228
branch
from
December 12, 2023 16:24
74016f4
to
1eddbae
Compare
Azure Pipelines successfully started running 1 pipeline(s). |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
bart-vmware
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component/Configuration
Issues related to Configuration providers
ReleaseLine/3.x
Identified as a feature/fix for the 3.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings #1228 to 3.x
Fixes #1226
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.