Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport IDisposable ConfigProviders to 3.2 #1230

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Backport IDisposable ConfigProviders to 3.2 #1230

merged 4 commits into from
Dec 13, 2023

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Dec 11, 2023

Description

Brings #1228 to 3.x

Fixes #1226

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess
build 3.2.7
bdd422b
@TimHess
Dispose configuration providers
ec41f8f 
* Fixed: Placeholder configuration provider should dispose child providers
* Fixed: ConfigServer configuration provider should dispose internal timer
@TimHess TimHess added Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Dec 11, 2023
@TimHess TimHess added this to the 3.2.7 milestone Dec 11, 2023
@TimHess TimHess self-assigned this Dec 11, 2023
@TimHess TimHess changed the title Backport IDisposable ConfigProviders Backport IDisposable ConfigProviders to 3.2 Dec 11, 2023
@TimHess TimHess force-pushed the backport_1228 branch 3 times, most recently from 64b3d49 to ae3f0a5 Compare December 11, 2023 23:09
@TimHess TimHess marked this pull request as ready for review December 12, 2023 01:03
@TimHess
Copy link
Member Author

TimHess commented Dec 12, 2023 •
edited
Loading

/azp run Steeltoe.All

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess TimHess force-pushed the backport_1228 branch 2 times, most recently from b7d1ea5 to 74016f4 Compare December 12, 2023 16:13
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TimHess TimHess merged commit ce870f0 into release/3.2 Dec 13, 2023
19 checks passed
@TimHess TimHess deleted the backport_1228 branch December 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart-vmware bart-vmware bart-vmware approved these changes

Assignees

@TimHess TimHess

Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
3.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@TimHess @bart-vmware