-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul :: Add tests to cover health check path being used when heartbeat is off #1245
Merged
TimHess
merged 3 commits into
SteeltoeOSS:release/3.2
from
cieciurm:fix/health-check-path
Jan 18, 2024
Merged
Consul :: Add tests to cover health check path being used when heartbeat is off #1245
TimHess
merged 3 commits into
SteeltoeOSS:release/3.2
from
cieciurm:fix/health-check-path
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for heartbeat on/off - Add tests for negative port
cieciurm
force-pushed
the
fix/health-check-path
branch
from
January 11, 2024 14:28
d27f8f2
to
991347c
Compare
TimHess
reviewed
Jan 16, 2024
cieciurm
commented
Jan 17, 2024
TimHess
added
ReleaseLine/3.x
Identified as a feature/fix for the 3.x release line
Component/Discovery
Issues related to Steeltoe Service Discovery
labels
Jan 17, 2024
This was referenced Jan 17, 2024
cieciurm
changed the title
Consul :: Fix health check path is not working when heartbeat is on
Consul :: Add tests to cover health check path being used when heartbeat is off
Jan 18, 2024
TimHess
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/azp run Steeltoe.All |
Azure Pipelines successfully started running 1 pipeline(s). |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
CI failures are unrelated |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component/Discovery
Issues related to Steeltoe Service Discovery
ReleaseLine/3.x
Identified as a feature/fix for the 3.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi all,
This PR fixes an issue when health check path is not respected when heartbeat is enabled.
This is a very simple attempt to fix the issue, by moving the short circuiting statement couple of lines lower.
Please let me know if it's too simple ;)
I've added unit tests to cover the issue scenario.
As a bonus, I've added a unit test to assert an exception being thrown when the specified port is a negative number.
If the solution is approved, then I can submit a similar fix for the v4 version (targeting
main
branch)Fixes #1062
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.