Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for application configuration service in 3.2 line #1269

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Mar 7, 2024

Description

#1196 for 3.x -- notable difference here (for now) is this variant always replaces . with : in configuration keys found in the binding in order to align with how the config server client processes configuration

Also fixes some violations of CA2017

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/enhancement New feature or request Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line labels Mar 7, 2024
@TimHess TimHess added this to the 3.2.7 milestone Mar 7, 2024
@TimHess TimHess requested a review from bart-vmware March 7, 2024 21:55
@TimHess TimHess self-assigned this Mar 7, 2024
@TimHess
Copy link
Member Author

TimHess commented Mar 7, 2024

/azp run Steeltoe.All

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TimHess
Copy link
Member Author

TimHess commented Mar 8, 2024

Companion sample PR SteeltoeOSS/Samples#318

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

sonarcloud bot commented Mar 28, 2024

@TimHess TimHess merged commit f4fe92f into release/3.2 Mar 28, 2024
19 checks passed
@TimHess TimHess deleted the acs_initial branch March 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants