Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cancellable calls #37

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix Cancellable calls #37

merged 1 commit into from
Apr 3, 2020

Conversation

pzhuk
Copy link
Contributor

@pzhuk pzhuk commented Apr 3, 2020

  1. Try to press Cancel in products admin menu - dead end, need to restart with /start
  • at least 2 more places with same behaivour
  1. Try to press Cancel in User mode, when doing credit card refill - oops, server error

Both were fixed by proper cancellable argument use CancelSignal signal handling

@Steffo99
Copy link
Owner

Steffo99 commented Apr 3, 2020

Whoops! Nice catch!

I should have tested 3e49f7c a bit more...

@Steffo99 Steffo99 merged commit 23febf1 into Steffo99:master Apr 3, 2020
@Steffo99 Steffo99 added the bug Something that doesn't work as expected. label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that doesn't work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants