Skip to content

Commit

Permalink
url encoding for search string again
Browse files Browse the repository at this point in the history
  • Loading branch information
StegSchreck committed Jul 24, 2017
1 parent 5471abd commit aa371d2
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 6 deletions.
5 changes: 4 additions & 1 deletion RatS/criticker/criticker_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import time
import urllib.parse

from bs4 import BeautifulSoup
from selenium.common.exceptions import NoSuchElementException
Expand All @@ -12,7 +13,9 @@ def __init__(self, args):
super(CritickerRatingsInserter, self).__init__(Criticker(args), args)

def _search_for_movie(self, movie):
self.site.browser.get('https://www.criticker.com/?search=%s&type=films' % movie['title'])
search_url = 'https://www.criticker.com/?search=%s&type=films' % \
urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)

@staticmethod
def _get_search_results(search_result_page):
Expand Down
4 changes: 3 additions & 1 deletion RatS/flixster/flixster_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import re
import time
import urllib.parse

from bs4 import BeautifulSoup
from selenium.common.exceptions import NoSuchElementException
Expand Down Expand Up @@ -37,7 +38,8 @@ def _is_empty_search_result(self):
return 'Sorry, no results found for' in self.site.browser.find_element_by_tag_name('h1').text

def _search_for_movie(self, movie):
self.site.browser.get('https://www.flixster.com/search/?search=%s' % movie['title'].encode('ISO-8859-1'))
search_url = 'https://www.flixster.com/search/?search=%s' % urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)
time.sleep(1)
return '/movie/' in self.site.browser.current_url # already on movie_details_page

Expand Down
5 changes: 4 additions & 1 deletion RatS/imdb/imdb_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import re
import time
import urllib.parse

from bs4 import BeautifulSoup

Expand All @@ -12,7 +13,9 @@ def __init__(self, args):
super(IMDBRatingsInserter, self).__init__(IMDB(args), args)

def _find_movie(self, movie):
self.site.browser.get('http://www.imdb.com/find?s=tt&ref_=fn_al_tt_mr&q=%s' % movie['title'])
search_url = 'http://www.imdb.com/find?s=tt&ref_=fn_al_tt_mr&q=%s' % \
urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)
time.sleep(1)
search_result_page = BeautifulSoup(self.site.browser.page_source, 'html.parser')
search_results_list = search_result_page.find(class_='findList')
Expand Down
4 changes: 3 additions & 1 deletion RatS/listal/listal_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import re
import time
import urllib.parse

from bs4 import BeautifulSoup
from selenium.common.exceptions import TimeoutException
Expand All @@ -13,7 +14,8 @@ def __init__(self, args):
super(ListalRatingsInserter, self).__init__(Listal(args), args)

def _search_for_movie(self, movie):
self.site.browser.get('http://www.listal.com/search/movies/%s' % movie['title'])
search_url = 'http://www.listal.com/search/movies/%s' % urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)

@staticmethod
def _get_search_results(search_result_page):
Expand Down
5 changes: 4 additions & 1 deletion RatS/metacritic/metacritic_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import time
import urllib.parse

from bs4 import BeautifulSoup

Expand All @@ -11,7 +12,9 @@ def __init__(self, args):
super(MetacriticRatingsInserter, self).__init__(Metacritic(args), args)

def _search_for_movie(self, movie):
self.site.browser.get('http://www.metacritic.com/search/movie/%s/results' % movie['title'])
search_url = 'http://www.metacritic.com/search/movie/%s/results' % \
urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)

@staticmethod
def _get_search_results(search_result_page):
Expand Down
4 changes: 3 additions & 1 deletion RatS/trakt/trakt_ratings_inserter.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import time
import urllib.parse

from bs4 import BeautifulSoup

Expand All @@ -11,7 +12,8 @@ def __init__(self, args):
super(TraktRatingsInserter, self).__init__(Trakt(args), args)

def _search_for_movie(self, movie):
self.site.browser.get('https://trakt.tv/search/?query=%s' % movie['title'])
search_url = 'https://trakt.tv/search/?%s' % urllib.parse.urlencode({'query': movie['title']})
self.site.browser.get(search_url)

@staticmethod
def _get_search_results(search_result_page):
Expand Down

0 comments on commit aa371d2

Please sign in to comment.