Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifacts in constellations artwork #1945

Closed
alex-w opened this issue Oct 2, 2021 · 12 comments
Closed

Artifacts in constellations artwork #1945

alex-w opened this issue Oct 2, 2021 · 12 comments
Assignees
@gzotti
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
0.21.3

Comments

@alex-w
Copy link
Member

alex-w commented Oct 2, 2021 •
edited
Loading

Expected Behaviour

Rendering artwork in sky cultures without artifacts and clipping

Actual Behaviour

Rendering artwork in sky cultures in some time has clipping and artifacts, see right side on the screenshot.
stellarium-014

Steps to reproduce

  1. Run Stellarium
  2. Enable displaying artwork (R)
  3. Move the sky

System

  • Stellarium version: master
  • Operating system: Ubuntu 20.04.3 LTS
  • Graphics Card: NVIDIA Corporation GP107 [GeForce GTX 1050 Ti]
  • Screen type (if applicable): 1920x1080
@alex-w alex-w added bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash labels Oct 2, 2021
@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021

I can reproduce issue in version 0.21.2 too

@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021

Version 0.21.1 doesn't have this issue, so, this is a regress :(

@alex-w alex-w added this to the 0.21.3 milestone Oct 2, 2021
@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021 •
edited
Loading

The source of issue is commit 9232fba :-(

@gzotti any ideas?

@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021

Probably method Constellation::drawArt is not needed, because I don't see where is called.

The next problem - artwork is aberrated and not aberrated in same time, WTF?

@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021

@gzotti I see aberration is applied only for constellations artwork and nothing else - is this really need for constellation artwork?

@alex-w alex-w mentioned this issue Oct 2, 2021
Closed
12 tasks
@gzotti
Copy link
Member

gzotti commented Oct 2, 2021

Aberration is applied to constellation artwork, like to (almost) everything else. Sure, why not? Sorry, I currently cannot reproduce this. What projection and FoV?

@gzotti gzotti self-assigned this Oct 2, 2021
@alex-w
Copy link
Member Author

alex-w commented Oct 2, 2021

Standard stereographic projection and all FOV

@gzotti
Copy link
Member

gzotti commented Oct 2, 2021

Finally I can reproduce it in Ubuntu, but not Windows. Driver problem? Will investigate (also your PR) next week.

@alex-w
Copy link
Member Author

alex-w commented Nov 12, 2021

No issue on Mac

@gzotti gzotti closed this as completed in ea335c3 Nov 13, 2021
@gzotti
Copy link
Member

gzotti commented Nov 13, 2021

Technically this is not the cleanest solution. I don't understand why the same code works on the other platforms but not on Linux. The result now is that the uncritical constellation artwork does not follow aberration shift (~20"). This would have been more relevant if the aberration exaggeration could have been increased much more than it turned out to be possible.

@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
0.21.3
Development

Successfully merging a pull request may close this issue.

Fix rendering issues for artwork of constellations Stellarium/stellarium
2 participants
@alex-w @gzotti