Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic add the group of satellites #2125

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Dec 24, 2021

Added code to automatic add the group of satellites, based on Celestrak groups

Description

I've added code to saving source of TLE into TleData struct and use this data to add new group of satellites as filename of URL. The feature works for Celestrak sources and for newly added satellites only.

Fixes #1636 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

For example satellite "ISS (NAUKA)" included into list of stations (see https://celestrak.com/NORAD/elements/stations.txt). If this satellite already added, then check his groups (he shouldn't contains any group), remove the satellite and update TLE. Find the ISS (NAUKA) and check the group.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Added code to automatic add the group of satellites, based on Celestrak groups (see issue #1636)
@github-actions github-actions bot requested a review from gzotti December 24, 2021 18:40
@alex-w alex-w added the enhancement Improve existing functionality label Dec 24, 2021
@github-actions
Copy link

Hello @alex-w! Thank you for this enhancement.

@alex-w
Copy link
Member Author

alex-w commented Dec 24, 2021

@gzotti If PR is OK then please merge it.

@alex-w alex-w added this to the 0.21.3 milestone Dec 24, 2021
@alex-w alex-w merged commit d37b25f into master Dec 24, 2021
@alex-w alex-w deleted the satellites/groups-from-url branch December 24, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Development

Successfully merging this pull request may close these issues.

sat plugin: connect sources to groups
2 participants