Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update moment-timezone to the latest version 🚀 #1829

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 31, 2017

Version 0.5.14 of moment-timezone was just published.

Dependency moment-timezone
Current Version 0.5.13
Type dependency

The version 0.5.14 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of moment-timezone.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes 0.5.14

0.5.14 2017-10-30

  • Updated data to IANA TZDB 2017c. #552
  • Ensure Intl response is valid when guessing time zone. #553
  • Make all time zones available for guessing. #483
Commits

The new version differs by 14 commits.

  • e843cfd Release 0.5.14
  • 9d13d65 Update dev dependencies
  • 5a44e01 Merge pull request #483 from mj1856/tzguess
  • 0682d33 Merge pull request #553 from mj1856/develop
  • d12d11e Ensure Intl response is valid
  • ba10fc8 Merge pull request #552 from ssskip/2017c
  • d7b7564 1. Updated data to IANA TZDB 2017c
  • 15d1343 Merge pull request #348 from joekrill/issue-347-unix-timestamps-parsed-incorrectly
  • ac7e723 Merge pull request #505 from Sornelo/wall_time
  • 8ed751a Merge pull request #398 from ssskip/utc-offset
  • 014cf0c Convert to tz keeping wall time
  • 7083ff9 Make all zones available for guessing
  • 2540ea0 fix #397 zone.offset has been deprecated in favor of zone.utcOffset
  • 993ad2d Check for timestamp formats when parsing

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@rye
Copy link
Member

rye commented Oct 31, 2017

Yay, lockfiles!

@stodevx-bot
Copy link

stodevx-bot commented Oct 31, 2017

Warnings
⚠️
❗ Big PR!

We like to try and keep PRs under 400 lines, and this one was 1966 lines.

If the PR contains multiple logical changes, splitting each change into a separate PR will allow a faster, easier, and more thorough review.

Generated by 🚫 dangerJS

@hawkrives
Copy link
Member

… it removed eslint. I don't think it's supposed to remove eslint. Or flow-bin.

@rye
Copy link
Member

rye commented Oct 31, 2017

So... do I run npm i and commit the fix to that?

Can confirm that running npm i will bring everything it deleted back in.

@hawkrives
Copy link
Member

Sure, and I guess we can see if it deletes it all again on the next dependency update?

@rye
Copy link
Member

rye commented Oct 31, 2017

Yep.

Copy link
Member

@rye rye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp. I guess I'm okay with this now

@hawkrives hawkrives merged commit e1ee01d into master Oct 31, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/moment-timezone-0.5.14 branch October 31, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants