Skip to content

Fixed bug in python BART serialization #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fixed bug in python BART serialization #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stochtree/bart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ def to_json(self) -> str:
# Add parameter samples
if self.sample_sigma_global:
bart_json.add_numeric_vector("sigma2_global_samples", self.global_var_samples, "parameters")
if self.sample_sigma_global:
if self.sample_sigma_leaf:
bart_json.add_numeric_vector("sigma2_leaf_samples", self.leaf_scale_samples, "parameters")

return bart_json.return_json_string()
Expand Down Expand Up @@ -758,7 +758,7 @@ def from_json(self, json_string: str) -> None:
# Unpack parameter samples
if self.sample_sigma_global:
self.global_var_samples = bart_json.get_numeric_vector("sigma2_global_samples", "parameters")
if self.sample_sigma_global:
if self.sample_sigma_leaf:
self.leaf_scale_samples = bart_json.get_numeric_vector("sigma2_leaf_samples", "parameters")

# Mark the deserialized model as "sampled"
Expand Down
Loading