Fix pip install issue. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also includes the excludes='tests' so that the tests package doesn't get built in site-packages when installed, but it's presence in MANIFEST.in means it's still included in the sdist tar. This is unrelated to the pip install issue but I noticed it while installing. I can separate it out if you'd prefer. |
Add MANIFEST.in and exclude tests in setup.py in order to exclude tests from being added to site-packages, but still included in the sdist. README and CHANGELOG is needed to build from sdist. StoicLoofah#44
StoicLoofah
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MANIFEST.in and exclude tests in setup.py in order to
exclude tests from being added to site-packages, but still
included in the sdist. README and CHANGELOG is needed to
build from sdist.