repeater export fix #307
Merged
repeater export fix #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairoprez
reviewed
Nov 21, 2020
There was a problem hiding this comment.
@Crabcyborg the code looks good and the Repeater Export issue Strategy11/formidable-pro#2766 is fixed
|
Thanks so much for the fix @Crabcyborg and the testing @jairoprez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Strategy11/formidable-pro/issues/2766
The issue here is that the metas aren't saved in the database, so I need to look at the repeater's fields and fill in the blanks as I populate the repeater data. There's really only one place that's possible to set it, in this repeater fill function after the loop. Added several unit tests, but they're in a separate PR in pro