feat(Player): add options menu #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklhtv
requested changes
Nov 2, 2022
src/routes/Player/Player.js
Outdated
| optionsMenuOpen ? | ||
| <OptionsMenu | ||
| className={classnames(styles['layer'], styles['menu-layer'])} | ||
| stream={videoState.stream} |
There was a problem hiding this comment.
player.selected.stream might be better here, because when the video throws error, videoState.stream will be null
…into feat/player-options-menu
…into feat/player-options-menu
nklhtv
requested changes
Nov 30, 2022
| toast.show({ | ||
| type: 'error', | ||
| title: 'Error', | ||
| message: 'Failed to copy stream link. Try to enable your browser permission.', |
There was a problem hiding this comment.
can we also unclude the streamUrl into the message
| // const { core } = useServices(); | ||
| const toast = useToast(); | ||
| const streamUrl = React.useMemo(() => { | ||
| return stream !== null ? |
There was a problem hiding this comment.
ytId case must also be handled here.
we kind of handle it already in external_player but the url case is not suitable for this feature.
I suggest we refactor stremio-core by adding one more field url to ExternalPlayerLink which will be the same as href except for this case, then use deepLinks api here
elpiel
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.