feat: player external play #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Code looks good to me, however, testing under Firefox gives me a few problems:
https://user-images.githubusercontent.com/8925621/228165968-f0ec296b-ba93-4035-a138-3a70db8c7c2e.mp4
- I couldn't find a single stream that is supported 😅
2. Clicking on the 3 dots menu, I get multiple errors in the console and I get redirected to:
link
Errors:
Uncaught TypeError: streamingServer.playbackDevices is undefined
The above error occurred in the <Player> component
Uncaught TypeError: core.transport is null
The above error occurred in the <ServicesToaster> component
The issues above were caused by not running npm install before testing the PR.
Sorry about that!
elpiel
reviewed
Apr 7, 2023
elpiel
reviewed
Apr 7, 2023
elpiel
approved these changes
Apr 20, 2023
| <Option | ||
| key={id} | ||
| icon={'ic_vlc'} | ||
| label={`Play in ${name}`} |
There was a problem hiding this comment.
- Should be translated in future PR
| streamingUrl || downloadUrl ? | ||
| <Option | ||
| icon={'ic_link'} | ||
| label={'Copy Stream Link'} |
There was a problem hiding this comment.
- Should be translated in future PR
| @@ -38,55 +38,78 @@ const OptionsMenu = ({ className, stream }) => { | |||
| toast.show({ | |||
| type: 'error', | |||
| title: 'Error', | |||
| message: `Failed to copy stream link: ${streamUrl}`, | |||
| message: `Failed to copy stream link: ${streamingUrl || downloadUrl}`, | |||
There was a problem hiding this comment.
- Should be translated in future PR?!
| case 'PlayingOnDevice': { | ||
| toast.show({ | ||
| type: 'success', | ||
| title: `Stream opened in ${args.device}`, |
There was a problem hiding this comment.
- Should be translated in future PR
elpiel
reviewed
Apr 20, 2023
| const { Button } = require('stremio/common'); | ||
| const styles = require('./styles'); | ||
|
|
||
| const Option = ({ icon, label, deviceId, disabled, onClick }) => { |
There was a problem hiding this comment.
-
We should add some docs for parameters, e.g.:As discussed this is already very clear and will be much clearer if we switch to TypescriptonClickshould takedeviceIdparameterlabelshould be a translated string as the component doesn't translates it- etc.
nklhtv
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs and Issues
Stremio/stremio-core#421
Stremio/stremio-core#427
Stremio/stremio-core-web#40closed in favour of Stremio/stremio-core-web#41Feature
Add options to open streams in external players