Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configure button for addons #360

Merged
merged 5 commits into from
May 23, 2023
Merged

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Apr 26, 2023

Closes #174

localhost_8080_(TV) (27)
image
image

@tymmesyde tymmesyde marked this pull request as ready for review April 26, 2023 13:53
@Iheuzio
Copy link
Contributor

Iheuzio commented May 16, 2023

It is not working over on edge (Version 113.0.1774.42 (Official build) (64-bit))

After clicking the addon button there are errors

image

</Button>
<div className={styles['action-buttons-container']}>
{
!behaviorHints.configurationRequired && behaviorHints.configurable ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Site loads up until this point, error encountered with configurationRequired, it is not defined and throws a type error

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error for reference:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do npm install after checkout ?

@jaruba jaruba merged commit ea24b64 into development May 23, 2023
@nklhtv nklhtv deleted the feat/addons-configure branch May 25, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addon Settings
3 participants