Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iPad Detection #382

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix iPad Detection #382

merged 1 commit into from
Jun 2, 2023

Conversation

jaruba
Copy link
Member

@jaruba jaruba commented Jun 1, 2023 •
edited
Loading

iPad was detected as MacOS on Safari

@jaruba jaruba requested review from tymmesyde and TRtomasz June 1, 2023 03:26
TRtomasz
TRtomasz approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@TRtomasz TRtomasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still working fine on Android Windows and Mac dont have ipad to test it.

tymmesyde
tymmesyde approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@tymmesyde tymmesyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Linux with Chrome / Firefox and Android also with both

@jaruba jaruba merged commit 287197a into development Jun 2, 2023
@elpiel elpiel deleted the fix-ipad-detection branch July 25, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRtomasz TRtomasz TRtomasz approved these changes

@tymmesyde tymmesyde tymmesyde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaruba @tymmesyde @TRtomasz