-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate internal functions exposed in the public API #123
Comments
Yep, deprecating from the public API sounds good to me |
I have a question, why base64 should be abandoned? So far as I can tell passing base64 string as an input for reading Or there are another ways I'm missing? Thank you so much in advance for your answer. |
@shytikov this deprecates the object |
Currently, JSZip exposes a lot of internal functions :
These functions/objects are not documented and in my opinion not really useful outside JSZip. The base64/crc32/utf8 methods may have some uses for other people but their signatures are sometimes surprising (utf8encode takes a string and return a string for example).
I think we should deprecate the list above (keep them internally but flag their inclusion in the public API as deprecated).
Thoughts, anyone ?
The text was updated successfully, but these errors were encountered: