Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom mime-types, ie: "application/ods". #199

Merged
merged 3 commits into from
Feb 18, 2015

Conversation

mind-ar
Copy link
Contributor

@mind-ar mind-ar commented Jan 23, 2015

Signed-off-by: Manuel Nuñez yo.elmanu@gmail.com

Signed-off-by: Manuel Nuñez <yo.elmanu@gmail.com>
@dduponchel
Copy link
Collaborator

It looks good :)
It just need two more things before merging this : documentation and test. Could you add the new option in the documentation ? For the tests, we already have a assertion on the type here, checking that the new option updates the type of the generated blob should be enough.

min1974 added 2 commits January 29, 2015 20:06
Added information for the new option "mimeType"
Added test for mimeType
@mind-ar
Copy link
Contributor Author

mind-ar commented Jan 29, 2015

hi, sorry if any error in my code/documentation. I'm a noob in english, Node.js and Git :)

dduponchel added a commit that referenced this pull request Feb 18, 2015
Added support for custom mime-types, ie: "application/ods".
@dduponchel dduponchel merged commit 8e21585 into Stuk:master Feb 18, 2015
@dduponchel dduponchel mentioned this pull request Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants