Added support for custom mime-types, ie: "application/ods". #199

Merged
merged 3 commits into from Feb 18, 2015

Projects

None yet

2 participants

@min1974
Contributor
min1974 commented Jan 23, 2015

Signed-off-by: Manuel Nuñez yo.elmanu@gmail.com

@min1974 min1974 Added support for custom mime-types, ie: "application/ods"
Signed-off-by: Manuel Nuñez <yo.elmanu@gmail.com>
78579e4
@dduponchel
Collaborator

It looks good :)
It just need two more things before merging this : documentation and test. Could you add the new option in the documentation ? For the tests, we already have a assertion on the type here, checking that the new option updates the type of the generated blob should be enough.

min1974 added some commits Jan 29, 2015
@min1974 min1974 Update generate.md
Added information for the new option "mimeType"
357e718
@min1974 min1974 Update test.js
Added test for mimeType
7b35405
@min1974
Contributor
min1974 commented Jan 29, 2015

hi, sorry if any error in my code/documentation. I'm a noob in english, Node.js and Git :)

@dduponchel dduponchel merged commit 8e21585 into Stuk:master Feb 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@dduponchel dduponchel referenced this pull request Mar 10, 2015
Merged

Release v2.5.0 #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment