New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom mime-types, ie: "application/ods". #199

Merged
merged 3 commits into from Feb 18, 2015

Conversation

Projects
None yet
2 participants
@mind74
Copy link
Contributor

mind74 commented Jan 23, 2015

Signed-off-by: Manuel Nuñez yo.elmanu@gmail.com

Added support for custom mime-types, ie: "application/ods"
Signed-off-by: Manuel Nuñez <yo.elmanu@gmail.com>
@dduponchel

This comment has been minimized.

Copy link
Collaborator

dduponchel commented Jan 24, 2015

It looks good :)
It just need two more things before merging this : documentation and test. Could you add the new option in the documentation ? For the tests, we already have a assertion on the type here, checking that the new option updates the type of the generated blob should be enough.

mind74 added some commits Jan 29, 2015

Update generate.md
Added information for the new option "mimeType"
Update test.js
Added test for mimeType
@mind74

This comment has been minimized.

Copy link
Contributor

mind74 commented Jan 29, 2015

hi, sorry if any error in my code/documentation. I'm a noob in english, Node.js and Git :)

dduponchel added a commit that referenced this pull request Feb 18, 2015

Merge pull request #199 from min1974/master
Added support for custom mime-types, ie: "application/ods".

@dduponchel dduponchel merged commit 8e21585 into Stuk:master Feb 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dduponchel dduponchel referenced this pull request Mar 10, 2015

Merged

Release v2.5.0 #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment