Improve encoding support #211

merged 2 commits into from Mar 9, 2016


None yet

2 participants


This pull request adds decodeFileName in load() and encodeFileName in generate(). These options allow to read / generate zip files with non-UTF-8 file names / comments (Windows Compressed Folders doesn't seem to support UTF-8 entries for example).

Fix #210

dduponchel added some commits Apr 14, 2015
@dduponchel dduponchel Add decodeFileName in load().
Some archive managers use the machine encoding to generate the file name and
comment. The user can recover the content of a file not encoded in UTF-8
but can't do anything for the file name. This new option adds the
ability to decode file names and comments with a custom algorithm.

See #210.
@dduponchel dduponchel Add encodeFileName in generate().
This option allows the user to generate a zip file with a custom encoding
for the entry file name / comment. See also "decodeFileName" in load().
Not using UTF-8 when generating a zip file is maybe asking for troubles but
some archive managers (Windows Compressed Folders for example) don't
support well unicode stuff.

See #210.
@Stuk Stuk merged commit 585812b into Stuk:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
@dduponchel dduponchel deleted the dduponchel:improve_encoding_support branch Mar 11, 2016
@dduponchel dduponchel referenced this pull request Mar 22, 2016

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment