New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve encoding support #211

Merged
merged 2 commits into from Mar 9, 2016

Conversation

Projects
None yet
2 participants
@dduponchel
Collaborator

dduponchel commented Apr 16, 2015

This pull request adds decodeFileName in load() and encodeFileName in generate(). These options allow to read / generate zip files with non-UTF-8 file names / comments (Windows Compressed Folders doesn't seem to support UTF-8 entries for example).

Fix #210

dduponchel added some commits Apr 14, 2015

Add decodeFileName in load().
Some archive managers use the machine encoding to generate the file name and
comment. The user can recover the content of a file not encoded in UTF-8
but can't do anything for the file name. This new option adds the
ability to decode file names and comments with a custom algorithm.

See #210.
Add encodeFileName in generate().
This option allows the user to generate a zip file with a custom encoding
for the entry file name / comment. See also "decodeFileName" in load().
Not using UTF-8 when generating a zip file is maybe asking for troubles but
some archive managers (Windows Compressed Folders for example) don't
support well unicode stuff.

See #210.

Stuk added a commit that referenced this pull request Mar 9, 2016

@Stuk Stuk merged commit 585812b into Stuk:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:improve_encoding_support branch Mar 11, 2016

@dduponchel dduponchel referenced this pull request Mar 22, 2016

Merged

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment