utils.delay: use macro tasks instead of micro tasks. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As says the documentation of [asap](https://github.com/kriskowal/asap), > ASAP strives to schedule events to occur before yielding for IO, > reflow, or redrawing. The goal of async methods in JSZip is to not freeze the browser, a macro task is a better choice here. See https://github.com/YuzuJS/setImmediate#macrotasks-and-microtasks for a description of micro/macro tasks. Fix Stuk#280.
The stream test was too fragile and randomly broke on some devices. While trying to debug it, I also improved the reporting of errors in saucelabs.
|
@CVex2150J could you confirm that this pull request fixes your issue ? I rebuilt the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As says the documentation of asap,
The goal of async methods in JSZip is to not freeze the browser, a macro task
is a better choice here. See
https://github.com/YuzuJS/setImmediate#macrotasks-and-microtasks for a
description of micro/macro tasks.
Fix #280.