Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File specific compression settings. #42

Merged
merged 3 commits into from
Mar 30, 2013
Merged

File specific compression settings. #42

merged 3 commits into from
Mar 30, 2013

Conversation

amarcu5
Copy link

@amarcu5 amarcu5 commented Mar 27, 2013

I needed this feature for a project I was involved with. No point compressing files that are already compressed...

@dduponchel
Copy link
Collaborator

Thanks for the pull request !

Could you add this in the documentation ? For the file(name) and file(name, data [,options]).

You also have an issue with the unit test unknown compression throws an exception : the exception is no longer thrown because the test JSZip object has no file.

@amarcu5
Copy link
Author

amarcu5 commented Mar 29, 2013

All fixed up.

dduponchel added a commit that referenced this pull request Mar 30, 2013
File specific compression settings.
@dduponchel dduponchel merged commit c91fe95 into Stuk:master Mar 30, 2013
@dduponchel
Copy link
Collaborator

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants