New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#296 - Replacing `window` references with `self` to allow running in a WebWorker #468

Merged
merged 3 commits into from Nov 5, 2017

Conversation

Projects
None yet
2 participants
@Draccoz
Contributor

Draccoz commented Oct 15, 2017

Fixing the issue preventing the use of jszip in a WebWorker.

@dduponchel

This comment has been minimized.

Show comment
Hide comment
@dduponchel

dduponchel Nov 5, 2017

Collaborator

I'm ok with the change (thank you!), I just pushed a new commit to remove the changes in the dist/ folder.
The build is now KO in nodejs 0.10 and 0.12, likely because of Medium/phantomjs/issues/753.
I'll merge this one and fix the build in an other pull request.

Collaborator

dduponchel commented Nov 5, 2017

I'm ok with the change (thank you!), I just pushed a new commit to remove the changes in the dist/ folder.
The build is now KO in nodejs 0.10 and 0.12, likely because of Medium/phantomjs/issues/753.
I'll merge this one and fix the build in an other pull request.

@dduponchel dduponchel merged commit 6aa06da into Stuk:master Nov 5, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@dduponchel dduponchel referenced this pull request Nov 9, 2017

Merged

Release 3.1.5 #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment