Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null type to currentFile in metadata #826

Merged
merged 2 commits into from
May 17, 2022
Merged

Add null type to currentFile in metadata #826

merged 2 commits into from
May 17, 2022

Conversation

zakarynichols
Copy link
Contributor

When providing an onUpdate callback when generating an archive I've found that when percent reaches 100 the currentFile property is null.

This comment in the code describes this behavior but the typescript does not match.

The null type simply needs to be added to the declaration file.

@Stuk Stuk merged commit f7ec7e6 into Stuk:main May 17, 2022
@emilbonnek emilbonnek mentioned this pull request Jul 19, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 17, 2023
Open
@NateRadebaugh NateRadebaugh mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zakarynichols @Stuk