[BUG] <hr> no longer works as of 2.1.0

[britannio]

Describe the bug:

The <hr> tag no longer produces a horizontal line as expected although the vertical spacing is now even. I caught this issue using https://pub.dev/packages/golden_toolkit so maybe it could be applied to this package to mitigate future regressions.

HTML to reproduce the issue:

<p>First Paragraph</p><hr><p>Second Paragraph</p>

Html widget configuration:

import 'package:flutter/material.dart';
import 'package:flutter_html/flutter_html.dart';

void main() {
  final data = '<p>First Paragraph</p><hr><p>Second Paragraph</p>';
  final app = MaterialApp(
    home: ColoredBox(color: Colors.white, child: Html(data: data)),
  );
  return runApp(app);
}

v2.0.0	v2.1.0

A picture of a cute animal (not mandatory but encouraged)

[britannio]

9192f93 introduced this bug.

[britannio]

cc @tneotia

[tneotia]

Ah yes that makes sense. Sorry I've been a little busy with other projects but hopefully tomorrow I can push a PR for this. Thanks for your patience!

[britannio]

Btw, britannio@4a9020b is a potential fix and it's the one i'm using for now.

Essentially, despite <hr> tags having no children, they are still rendered via ContainerSpan, specifically via the border style attribute. I see golden tests but presumably they're disabled :(.

[tneotia]

Thanks, that will sort of work but doesn't cover the case of an empty paragraph that has a border style set in the HTML. I think the best way to go would be to check the element localName to see if it is allowed to render with empty children.

Yea we are pretty lacking on tests, I don't know much about how they work so I haven't been able to improve that side of the library.

[tneotia]

PR made, thanks for the report and finding the root cause!