Table: make width property not mandatory on <col> elements.
#420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-berger
suggested changes
Oct 12, 2020
emagnier
force-pushed
the
table-widths
branch
from
2a85509 to
d25f3ae
Compare
ryan-berger
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
widthproperty not mandatory on<col>elements.e.g. on a table with 2 columns, you can now specify the width of the 1st column, but not the 2nd, so the 2nd one will automatically take all the remaining width space.
Actually if you don't specify a
widthon all or some of the<col>elements, you get an error whereFailed assertion: line 133 pos 47: 'value != null': is not true.