Images consume the screen height if the source is larger than needed #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource is larger than intrinsic height (given the available horizontal space)
|
Will this not break the implementation created for the flutter_layout_grid image issue? I think the height parameter was constraining the height of the image so the table wouldn't look off. |
|
No; I checked that. |
|
@ryan-berger can yo merge this too, before rolling out a new release? |
ryan-berger
suggested changes
Jan 13, 2021
There was a problem hiding this comment.
@erickok As soon as you fix this I will merge and roll it all to master, possibly tonight or tomorrow depending on how quick you are (no worries)
ryan-berger
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #485 where images consume the screen height if the source is larger than the available space