Skip to content

Conversation

erickok
Copy link
Contributor

@erickok erickok commented Jan 29, 2021

Fixes #515 by properly, recursively applying linking and styling to text spans inside tags

Copy link
Contributor

@tneotia tneotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erickok
Copy link
Contributor Author

erickok commented Feb 4, 2021

@ryan-berger could you also review this? I can't merge without your review.

@ryan-berger
Copy link
Contributor

@erickok Just to make sure, this doesn't cause a regression with the image inside a link having and underline right?

@erickok
Copy link
Contributor Author

erickok commented Feb 4, 2021

Screenshot 2021-02-04 at 21 28 55
Nope that is still workign well!

Copy link
Contributor

@ryan-berger ryan-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM!

@ryan-berger ryan-berger merged commit f24f461 into Sub6Resources:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links not working when an other tag is inside the <a> tag and tags not working in general within <a> tags

3 participants