Use intrinsic with for <table> columns with otherwise undefined size #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Sub6Resources#491 specifically, and also updates flutter_layout_grid to a much improved version
tneotia
reviewed
Feb 4, 2021
Comment on lines
+63
to
+70
| : IntrinsicContentTrackSize(); | ||
| } else if (colWidth != null) { | ||
| final fixedPxSize = double.tryParse(colWidth); | ||
| return fixedPxSize != null | ||
| ? FixedTrackSize(fixedPxSize) | ||
| : FlexibleTrackSize(1); | ||
| : IntrinsicContentTrackSize(); | ||
| } else { | ||
| return FlexibleTrackSize(1); | ||
| return IntrinsicContentTrackSize(); |
There was a problem hiding this comment.
Does this new flutter_layout_grid parameter correctly size when images are in a table? Curious to know whether this fixes that one issue we were having with small images inside tables.
There was a problem hiding this comment.
Awesome! I'm going to remove my comment on your image render proposal since this takes care of that.
|
@ryan-berger could you review this? I can't self-review so I can't merge. |
|
@erickok Yup, I can, but let me also up your permissions :) |
|
@erickok Oh, actually, can't up your permissions for this one. That would require ownership I believe? Unless we turn these requirements off.... Maybe a discussion we can have over email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #491 specifically, and also updates flutter_layout_grid to a much improved version