Skip to content

Fix failed assertion when tap/scrolling on any link #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Fix failed assertion when tap/scrolling on any link #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 1 addition & 30 deletions lib/src/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,38 +49,9 @@ class Context<T> {
// This class is a workaround so that both an image
// and a link can detect taps at the same time.
class MultipleTapGestureRecognizer extends TapGestureRecognizer {
bool _ready = false;

@override
void addAllowedPointer(PointerDownEvent event) {
if (state == GestureRecognizerState.ready) {
_ready = true;
}
super.addAllowedPointer(event);
}

@override
void handlePrimaryPointer(PointerEvent event) {
if (event is PointerCancelEvent) {
_ready = false;
}
super.handlePrimaryPointer(event);
}

@override
void resolve(GestureDisposition disposition) {
if (_ready && disposition == GestureDisposition.rejected) {
_ready = false;
}
super.resolve(disposition);
}

@override
void rejectGesture(int pointer) {
if (_ready) {
acceptGesture(pointer);
_ready = false;
}
acceptGesture(pointer);
}
}

Expand Down