Skip to content

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented Apr 28, 2021

Don't know if creating the templates via IDE will work but I tried anyways.

@ryan-berger
Copy link
Contributor

Before we merge, I saw something really silly in Docker's PR template the other day that I think we should add to all of our templates:

https://github.com/docker/cli/blob/master/.github/PULL_REQUEST_TEMPLATE.md

They have a section:

- A picture of a cute animal (not mandatory but encouraged)

Here's a good example:
docker/cli#3075

We don't HAVE to have it, but I find it a nice surprise to open a Github issue to find a picture of a cute animal (see above)

@tneotia
Copy link
Contributor Author

tneotia commented May 12, 2021

@ryan-berger I think that's pretty funny too, I added it in for kicks 😄

@erickok erickok merged commit 758867f into Sub6Resources:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants