Skip to content

Add support for the style tag #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 12, 2021
Merged

Add support for the style tag #655

merged 7 commits into from
May 12, 2021

Conversation

tneotia
Copy link
Contributor

@tneotia tneotia commented May 2, 2021 •
edited
Loading

Fixes #593 and sort of addresses #207 (we still don't support all the styles given in the example in that issue).

image

Test HTML 
<html>
<head>
<style>
body {
  background-color: lightblue;
}
</style>
<style>
h1 {
  color: white;
  text-align: center;
}
</style>
<style>
p {
  font-size: 20px;
}
</style>
</head>
<body>

<h1>My First CSS Example</h1>
<p style="color: blue;">This is a paragraph.</p>

</body>
</html>

Should we add a parameter to the Html widget to allow users to pass the external CSS as a string separate from the HTML data? Don't know if that would be useful but it wouldn't be difficult to implement at all. Done via Style.fromCSS function.

Also for some reason adding <head> to the document adds a space at the top of the doc, I don't know if the changes made in #646 will help that but I don't think so. Fixed

@erickok
Copy link
Contributor

erickok commented May 3, 2021

As for the tag occupying visible space, maybe render it explicitly as empty Container()?

@tneotia tneotia mentioned this pull request May 3, 2021
Merged
@tneotia

This comment has been minimized.

Sign in to view
tneotia added 2 commits May 3, 2021 12:21
@tneotia
Remove head from html_elements and fix empty space at the top of the …
380ca5a 
…document when using head > style
@tneotia
Merge branch 'master' of https://github.com/Sub6Resources/flutter_html …
9661568 
…into feature/style-tag-support

� Conflicts:
�	lib/style.dart
@tneotia
Copy link
Contributor Author

tneotia commented May 3, 2021

Fixed the empty space issue with the recent commit - for some reason the <html> tag was rendered as a TextContentElement with " " as the text, so it didn't get flagged and removed as an "empty" TextContentElement.

erickok
erickok approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@erickok erickok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but could you change all naming to camelCase?

@tneotia
Copy link
Contributor Author

tneotia commented May 12, 2021

@erickok done.

@erickok erickok merged commit 5de96d7 into Sub6Resources:master May 12, 2021
erickok added a commit to vrtdev/flutter_html that referenced this pull request Oct 1, 2021
@erickok
Prevent block tags with expliciut whitespace to be stripped; fixes Su…
5f93eab 
…b6Resources#796

This was a regression introduced in Sub6Resources#655
@erickok erickok mentioned this pull request Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erickok erickok erickok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Style tag support

2 participants

@tneotia @erickok