Skip to content

Fix hr not showing and improve hr spacing #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Fix hr not showing and improve hr spacing #750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff3fdba
Fix hr not showing and improve hr spacing
tneotia Jun 28, 2021
919ec5c
Merge branch 'master' of https://github.com/Sub6Resources/flutter_htm…
tneotia Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/html_parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ class HtmlParser extends StatelessWidget {
}

//Return the correct InlineSpan based on the element type.
if (tree.style.display == Display.BLOCK && tree.children.isNotEmpty) {
if (tree.style.display == Display.BLOCK &&
(tree.children.isNotEmpty || tree.element?.localName == "hr")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I don't think there are any other tags that render as block yet have no children. cf https://developer.mozilla.org/en-US/docs/Glossary/Empty_element

if (newContext.parser.selectable) {
return TextSpan(
style: newContext.style.generateTextStyle(),
Expand Down
3 changes: 2 additions & 1 deletion lib/src/styled_element.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,8 @@ StyledElement parseStyledElement(
styledElement.style = Style(
margin: EdgeInsets.symmetric(vertical: 7.0),
width: double.infinity,
border: Border(bottom: BorderSide(width: 1.0)),
height: 1,
backgroundColor: Colors.black,
display: Display.BLOCK,
);
break;
Expand Down