Skip to content

Table tag alignment #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Table tag alignment #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cc8a56
Prevent crash on empty <table> tags; fixes #893
erickok Nov 26, 2021
3da05e5
Fix whitespace rendering between list items; fixes #878
erickok Nov 26, 2021
a8467db
Merge remote-tracking branch 'upstream/master'
erickok Nov 29, 2021
678127e
Support alignment on table tag; fixes #856
erickok Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/html_parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ class HtmlParser extends StatelessWidget {
if (child is EmptyContentElement || child is EmptyLayoutElement) {
toRemove.add(child);
} else if (child is TextContentElement
&& tree.name == "body"
&& (tree.name == "body" || tree.name == "ul")
&& child.text!.replaceAll(' ', '').isEmpty) {
toRemove.add(child);
} else if (child is TextContentElement
Expand Down
6 changes: 6 additions & 0 deletions lib/src/layout_element.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class TableLayoutElement extends LayoutElement {
key: AnchorKey.of(context.parser.key, this),
margin: style.margin,
padding: style.padding,
alignment: style.alignment,
decoration: BoxDecoration(
color: style.backgroundColor,
border: style.border,
Expand Down Expand Up @@ -155,6 +156,11 @@ class TableLayoutElement extends LayoutElement {
max(0, columnMax - finalColumnSizes.length),
(_) => IntrinsicContentTrackSize());

if (finalColumnSizes.isEmpty || rowSizes.isEmpty) {
// No actual cells to show
return SizedBox();
}

return LayoutGrid(
gridFit: GridFit.loose,
columnSizes: finalColumnSizes,
Expand Down