Skip to content

add selene to contrib.json #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

add selene to contrib.json #100

merged 2 commits into from
Jul 22, 2020

Conversation

alihsaas
Copy link
Contributor

No description provided.

@braver
Copy link
Member

braver commented Jul 22, 2020

Thanks!

  • please place the entry in contrib.json in alphabetical order
  • preferably, cmd is a tuple, although a string also works
  • maybe add '${args}' in cmd if it needs to go before the filename

@kaste might have some more, but this looks simple enough otherwise

@kaste
Copy link
Member

kaste commented Jul 22, 2020

It looks like the linter does not read from stdin. In that case you also have to set tempfile_suffix = "-".

@alihsaas
Copy link
Contributor Author

Thanks! Applied the changes you requested!

@braver
Copy link
Member

braver commented Jul 22, 2020

🎉

@braver braver merged commit 55476b3 into SublimeLinter:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alihsaas @braver @kaste