Add syntax highlighting and completions for new color scheme preferences #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. There is another new setting |
|
Thanks, I missed that :) I may have to find a more reliable documentation (/website) differ, because https://github.com/maliayas/SublimeText_Documentation clearly isn't automated ;) |
FichteFoll
requested changes
Mar 30, 2018
| // ^^^^^^^^^^^^^^^^^^^^^^ entity.name.globals.sublime-color-scheme | ||
| // ^^^ meta.mapping.value.json string.quoted.double.json | ||
| // ^ constant.numeric.json | ||
| "selection_border": "#ffffff40", |
There was a problem hiding this comment.
That was obviously meant to be "tests".
I'll just add them myself, unless you beat me to it.
| 3: punctuation.definition.string.end.json | ||
| set: [expect-color-string-value, expect-colon] | ||
| - match: (")(shadow_width|popup_css|phantom_css)(") | ||
| - match: (")(shadow_width|popup_css|phantom_css|selection_corner_radius|selection_border_width)(") |
There was a problem hiding this comment.
I suppose the css keys should get their own match with this change, no?
keith-hall
force-pushed
the
3158_color_scheme
branch
from
6e0c104 to
5b68ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ST build 3158 added a couple of new color scheme "global" keys. This PR adds syntax highlighting and completions for those.