Skip to content

Conversation

VertigoRay
Copy link

This fixes Issue #4 on Win7 Ent x64 and OS X 10.6.8. Not tested on other systems.

This change ends a curly-bracket-variable by looking for any non-closing curly bracket character assuming there's an ending curly bracket available.

This improves the fix issued in #7.  Using the any character . causes it (in certain circumstances; I can provide examples if requested) to continue selection indefinitely. The modification that I've made causes the variable to end at the next curly bracket every time.

This fixes Issue SublimeText#4 on Win7 Ent x64 and OS X 10.6.8. Not tested on other systems.

This change ends a curly-bracket-variable by looking for any non-closing curly bracket character assuming there's an ending curly bracket available.

This improves the fix issued in SublimeText#7.  Using the any character (.) causes it (in certain circumstances; I can provide examples if requested) to continue selection indefinitely. The modification that I've made causes the variable to end at the next curly bracket every time.
@VertigoRay
Copy link
Author

For this particular case, nothing. I used it because of habit when I'm using capturing groups, but since captures aren't used, I honestly should have left it out. The regex [^}]+\\} works the same.

I've also figured out what you were talking about on #9. The reason I wasn't benefitting from the fix is because it was never built into the PowershellSyntax.tmLanguage file with AAAPackageDev as suggested in #8. The lazy capture fixed the issue I'm having after I put it into the XML manually, maybe someone should fix that? Since I had already put together my imgur album before seeing the lazy fix deal ... here's the link: http://imgur.com/a/yI8zi

I updated the test-file.ps1 file to include the lines of code that I have that create the error with the curly-bracket-variables so we have a more complete test-file on the project.

k ... http://imgur.com/0QMdB ;)

@FichteFoll
Copy link
Member

I can take care of this issue if @guillermooo is okay with that.

@guillermooo
Copy link
Member

@FichteFoll, feel free to go ahead with this is you're reasonably sure it'll work. (I haven't been following the issue closely; kind of busy with other stuff these days.)

@FichteFoll
Copy link
Member

Well, never used the edit feature from github before (because I mostly store my repos locally as well) but it works quite well.

@FichteFoll FichteFoll closed this Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants