Update PowerShell (to YAML and to PS3/4 syntax) #21

Jaykul · 2013-09-18T06:37:21Z

Not much to say here, just a long overdue push request to get this updated to PowerShell 3
NOTE: there's no WorkFlow or DSC syntax here -- just straight PowerShell.

…d badly)

Make it work for PowerShell 3 (and 4), fix MOST of the test cases

Fix variable highlighting

(It's still not quite 100%, but it'll work for me) Fix syntax highlighting! (It's still not quite 100%, but it'll work for me)

FichteFoll · 2013-09-18T14:43:32Z

You should take a look at the AAAPackageDev: Rearrange YAML Syntax Def command. Running it now will remove your comments, but I highly recommend running AAAPackageDev: Convert to YAML and Rearrange Syntax Definition when switching to a YAML def.

guillermooo · 2013-09-18T19:52:00Z

I'm confused. Are you guys working on ST2?

Jaykul · 2013-09-18T22:15:00Z

I'm not usually working on ST2, but when I needed to fix the PowerShell syntax, I (re)installed 2 so I could use AAAPackageDev to work with the JSON/YAML format rather than edit the tmLanguage file xml which I've never bothered groking (especially since that's how this syntax was obviously done originally).

Is there some other option that works on ST3?

FichteFoll · 2013-09-18T23:10:57Z

PackageDev will at some point be ST3 compatible, hopefully within the next few weeks. I don't know of any other plugin that does the syntax thing.

Jaykul · 2013-09-22T04:12:32Z

So I'm confused -- is there anything preventing this being merged?

guillermooo · 2013-09-22T07:58:38Z

@Jaykul No, it's just me. This will be merged when I find the time.

@FichteFoll Actually, it might be a good idea to start porting AAAPackageDev bit by bit? I might take a look at making the syntax translations work in ST3. So basically it'd be two tasks: silencing errors in ST3, making the syntax translations work and ensuring that everything keeps working in ST2. Ok, three tasks :)

FichteFoll · 2013-09-22T18:57:13Z

"bit by bit" is a thing ... well, it shouldn't actually be much work, I just need to find some time in my schedule. I'll see if I can do this tomorrow.

Also, there are some weird issues with relative imports in newer ST3 builds that might be a problem. I could work around it by hardcoding import AAAPackageDev.fileconv for the time, but of course the better solution would be fixing relative imports. And I should test how modifying sys.path works with .sublime-package zip archives

Jaykul · 2013-09-22T21:37:57Z

Yeah, I tried getting it working in ST3 based on changes someone else made
... but I never got past the "from . import lib" thing. I didn't spend
much time on it, just got fed up and reinstalled 2 side-by-side.

mkanet · 2013-11-10T04:41:06Z

Any chance we'll see an updated PS3 version anytime soon? There are plenty of people like me who don't post here, but been waiting months for an update..

guillermooo · 2013-11-10T07:45:33Z

I definitely want it (I'm the original author), but I don't have the time to look into it for now. Perhaps in a few weeks.

ntwb · 2013-11-12T04:48:04Z

I don't know all of the ins and outs of all the above that's mentioned above.

I just installed @Jaykul's fork in ST3 3047 portable on x64 Windows 8.1 and for the basic PowerShell needs I use it for it appears to be working for me.

mkanet · 2013-11-24T01:17:01Z

Sorry, I know this is the wrong place to ask, but curious if anyone here uses Bracket Highlighter? If so, has anyone updated it to recognize Powershell comment blocks? i.e., <# comments go here #>

ntwb · 2014-03-30T01:37:52Z

@Jaykul Do I need to have 'ConEmu' installed to work with your most recent commits? (I'd prefer not)

Jaykul · 2014-03-30T14:50:54Z

You shouldn't need ConEmu -- those changes are isolated in their own file, and it's just a couple of commands (which you'd have to associate a keystroke or something before they do anything)

I'll probably make a separate ConEmu addon ... it's just as useful with Python (or bash, or anything else that runs in ConEmu) as PowerShell...

gwojan · 2014-07-09T14:27:03Z

@Jaykul have you seen the stposh package? It seems to address a lot of the issues you've been trying to address and then some. I just started using Sublime so my comfort level is still quite low...

mkanet · 2014-07-09T17:11:27Z

@gwojan (or anyone), which ST package currently has more complete Powershell Version 3/4 support? I'm currently using Jaykul's version, labeled "Powershell v2"

gwojan · 2014-07-09T21:47:52Z

@mkanet I'm not really sure at this point. The stposh package seems pretty full featured at this point. I only recently found @Jaykul 's updates which I haven't had a chance to 'build' since I'm still struggling with Sublime. If I have a chance to fit it in in the next few days I'll report my findings back here.

vors · 2014-09-11T05:59:23Z

@guillermooo any updates about this pull request? I'd like to help with adding support for PowerShell v5. Should I use @Jaykul 's fork as a baseline?

Areas that I want to address:

DSC support: Configuration and Node keywords + scopes.
classes support: lots of thing, since classes are new feature in September 2014 preview.
3*) Auto-generate list of parameters for built-in cmdlet, so we will have autocomplition for parameter names.

guillermooo · 2014-09-11T06:03:48Z

It will probably take me some more time to merge this. But if someone can verify it could be merged without further review, that'd be great. Thanks for your interest, BTW!

vors · 2014-09-11T06:14:54Z

Great! I will help with merging this request. Thank you for a quick response :)

vors · 2014-09-11T06:28:03Z

Build/setup.py

@@ -1,591 +1,588 @@
-# encoding: utf-8


Please, use original CRLF line terminators so changes can be reviewed more easily.

vors · 2014-09-11T06:34:04Z

Build/setup.py

+      name='PowerShell',
+      version=PACKAGE_VERSION,
+      description='PowerShell support for Sublime Text.',
+      author='Joel Bennett',


Please, preserve original authors as well

vors · 2014-09-11T06:58:29Z

@Jaykul thank you, good work! I left few comments inlined. I didn't test .ps1 build scripts, although. Please, reduce the size of PR with preserving original ending (CLRF) in files that I mentioned. We may convert them to unix-style later, as a separate checkin. Now, it prevents effective reviewing.

Jaykul · 2014-09-11T16:30:55Z

I can do all of that. The ConEmu changes, honestly, I did not mean to include in this PR, I just forgot to make a branch. I'm on vacation this week (and have a late night tonight) but adding PS5 support has been on my todo list for this vacation, so since there's movement over here, I'll try to at least fix the changes tomorrow night :-)

Jaykul · 2014-10-03T04:03:52Z

OK, my deepest apologies to anyone who was tracking my fork (@vors), but ... the simplest thing was to just revert and --force my branch to get rid of all those ConEmu changes which should have been in a separate branch/repo.

guillermooo · 2014-10-03T06:04:07Z

I've tried this briefly and everything seems to be ok. This is one of the first syntax defs I created, so we'll probably need to revisit many things, but that can wait.

Thanks JayKul (and sorry for the long wait)!

Update PowerShell (to YAML and to PS3/4 syntax)

vors · 2014-10-03T07:17:07Z

Sweet

Jaykul · 2014-10-03T15:00:22Z

Great! 👍

Jaykul added 6 commits September 18, 2013 02:17

Add a bunch of new test cases (most of which fail, and are highlighte…

dc84ee4

…d badly)

Fix built-in variables

6baf0b6

Make it work for PowerShell 3 (and 4), fix MOST of the test cases

Switch to new YAML markup

dc23c18

Fix variable highlighting

Fix syntax highlighting!

43f1654

(It's still not quite 100%, but it'll work for me) Fix syntax highlighting! (It's still not quite 100%, but it'll work for me)

Fix build script (!?)

477de13

A final fix for variables

b8f8ac2

FichteFoll mentioned this pull request Sep 18, 2013

Small yaml fixes SublimeText/PackageDev#31

Merged

vors reviewed Sep 11, 2014
View reviewed changes

Build/setup.py

@@ -1,591 +1,588 @@

# encoding: utf-8

Copy link

Member

vors Sep 11, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use original CRLF line terminators so changes can be reviewed more easily.

vors reviewed Sep 11, 2014
View reviewed changes

Jaykul force-pushed the master branch from 63d343c to b8f8ac2 Compare October 3, 2014 03:29

Joel Bennett and others added 3 commits October 2, 2014 23:35

fix single-quote herestring and add PS4 tests

8d4ae61

Minor tweaks to tests (one actual fix on line 137)

2b54a41

Created symbol definition for functions

b6a23c1

guillermooo added a commit that referenced this pull request Oct 3, 2014

Merge pull request #21 from Jaykul/master

25ebc65

Update PowerShell (to YAML and to PS3/4 syntax)

guillermooo merged commit 25ebc65 into SublimeText:master Oct 3, 2014

Update PowerShell (to YAML and to PS3/4 syntax) #21

Update PowerShell (to YAML and to PS3/4 syntax) #21

Uh oh!

Conversation

Jaykul commented Sep 18, 2013

Uh oh!

FichteFoll commented Sep 18, 2013

Uh oh!

guillermooo commented Sep 18, 2013

Uh oh!

Jaykul commented Sep 18, 2013

Uh oh!

FichteFoll commented Sep 18, 2013

Uh oh!

Jaykul commented Sep 22, 2013

Uh oh!

guillermooo commented Sep 22, 2013

Uh oh!

FichteFoll commented Sep 22, 2013

Uh oh!

Jaykul commented Sep 22, 2013

Uh oh!

mkanet commented Nov 10, 2013

Uh oh!

guillermooo commented Nov 10, 2013

Uh oh!

ntwb commented Nov 12, 2013

Uh oh!

mkanet commented Nov 24, 2013

Uh oh!

ntwb commented Mar 30, 2014

Uh oh!

Jaykul commented Mar 30, 2014

Uh oh!

gwojan commented Jul 9, 2014

Uh oh!

mkanet commented Jul 9, 2014

Uh oh!

gwojan commented Jul 9, 2014

Uh oh!

vors commented Sep 11, 2014

Uh oh!

guillermooo commented Sep 11, 2014

Uh oh!

vors commented Sep 11, 2014

Uh oh!

vors Sep 11, 2014

Choose a reason for hiding this comment

Uh oh!

vors Sep 11, 2014

Choose a reason for hiding this comment

Uh oh!

vors commented Sep 11, 2014

Uh oh!

Jaykul commented Sep 11, 2014

Uh oh!

Jaykul commented Oct 3, 2014

Uh oh!

guillermooo commented Oct 3, 2014

Uh oh!

vors commented Oct 3, 2014

Uh oh!

Jaykul commented Oct 3, 2014

Uh oh!

Uh oh!