fixed here-string formating #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,7 @@ | |||
| </dict> | |||
| <dict> | |||
| <key>begin</key> | |||
| <string>@"$</string> | |||
| <string>^@"\n</string> | |||
There was a problem hiding this comment.
This would not work here:
$someVar = @"
hello
"@There was a problem hiding this comment.
Also, I think a lookahead would be preferable:
@"(?=\n)
There was a problem hiding this comment.
I believe that it works properly. With my change:
Without change:
Also using the lookahead gives the same result as the unmodified syntax file.
|
Thanks, for the PR. I've left a couple of comments. |
| @@ -205,9 +205,9 @@ | |||
| </dict> | |||
| <dict> | |||
| <key>begin</key> | |||
| <string>@'$</string> | |||
| <string>@'\n</string> | |||
There was a problem hiding this comment.
Sorry, I forgot to mention to do the same as above. Let's add a lookahead here too for consistency.
|
Not 100% compliant with PS syntax, but as it fixes an error, I'll merge this. Thanks @william-voyek ! |
guillermooo
added a commit
that referenced
this pull request
Oct 7, 2014
fixed here-string formating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting pull-request. Corrected line-ending issues.