-
Notifications
You must be signed in to change notification settings - Fork 887
[Bugfix:Autograding] Multiple docker debugging errors #11697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11697 +/- ##
============================================
- Coverage 22.48% 22.48% -0.01%
Complexity 9080 9080
============================================
Files 252 252
Lines 32612 32623 +11
Branches 83 83
============================================
+ Hits 7333 7334 +1
- Misses 25200 25210 +10
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Please check if the PR fulfills these requirements: * [ ] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant * [x] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? Fixes #11645 Currently, if there is a required docker image for an gradeable is missing, autograding submissions notify both students and instructors in the autograding results box. However, if multiple images are required and are missing, the subsequent errors overwrite the details of the previous error. ### What is the new behavior? The subsequent errors are appended to a list of errors and looped through to display each image error. ### Other information? Current behavior  New behavior  --------- Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Please check if the PR fulfills these requirements:
What is the current behavior?
Fixes #11645
Currently, if there is a required docker image for an gradeable is missing, autograding submissions notify both students and instructors in the autograding results box. However, if multiple images are required and are missing, the subsequent errors overwrite the details of the previous error.
What is the new behavior?
The subsequent errors are appended to a list of errors and looped through to display each image error.
Other information?
Current behavior

New behavior
