Skip to content

Conversation

Chriun
Copy link
Contributor

@Chriun Chriun commented Jun 2, 2025

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant
  • Screenshots are attached to Github PR if visual/UI changes were made

What is the current behavior?

Fixes #11645
Currently, if there is a required docker image for an gradeable is missing, autograding submissions notify both students and instructors in the autograding results box. However, if multiple images are required and are missing, the subsequent errors overwrite the details of the previous error.

What is the new behavior?

The subsequent errors are appended to a list of errors and looped through to display each image error.

Other information?

Current behavior
before

New behavior
after

Chriun added 2 commits June 2, 2025 11:15
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
@github-project-automation github-project-automation bot moved this to Seeking Reviewer in Submitty Development Jun 2, 2025
@automateprojectmangement automateprojectmangement bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jun 2, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes missing coverage. Please review.

Project coverage is 22.48%. Comparing base (09fddcb) to head (9c9f63f).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #11697      +/-   ##
============================================
- Coverage     22.48%   22.48%   -0.01%     
  Complexity     9080     9080              
============================================
  Files           252      252              
  Lines         32612    32623      +11     
  Branches         83       83              
============================================
+ Hits           7333     7334       +1     
- Misses        25200    25210      +10     
  Partials         79       79              
Flag Coverage Δ
autograder 21.44% <5.26%> (-0.08%) ⬇️
js 27.17% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.57% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 88.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Chriun added 4 commits June 2, 2025 14:35
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
@Chriun Chriun marked this pull request as ready for review June 2, 2025 19:09
@automateprojectmangement automateprojectmangement bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Jun 2, 2025
Copy link
Contributor

@JManion32 JManion32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to replicate the issue and found that it is now resolved:
Multiple Errors

I do want to note that I encountered this frog robot a few times while testing, however, I think this is just because of the way I was setting it up as well as how I was testing a similar PR today.

multiple docker images PR frogbot

@github-project-automation github-project-automation bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jun 2, 2025
@Chriun
Copy link
Contributor Author

Chriun commented Jun 2, 2025

I was able to replicate the issue and found that it is now resolved: Multiple Errors

I do want to note that I encountered this frog robot a few times while testing, however, I think this is just because of the way I was setting it up as well as how I was testing a similar PR today.

multiple docker images PR frogbot

Yes I was running into the same error because the previous docker error was stored in a single dictionary and persisted in that gradeable's autograding results box. The new behavior expects a list of error dictionaries so entering a gradeable with the lingering error in the old format will give an attribute error. This should work properly outside of that and would never occur normally (outside our development environment).

@bmcutler bmcutler merged commit 0317648 into main Jun 3, 2025
24 checks passed
@bmcutler bmcutler deleted the multiple-docker-images branch June 3, 2025 18:50
williamschen23 pushed a commit that referenced this pull request Jun 3, 2025
### Please check if the PR fulfills these requirements:

* [ ] Tests for the changes have been added/updated (if possible)
* [ ] Documentation has been updated/added if relevant
* [x] Screenshots are attached to Github PR if visual/UI changes were
made

### What is the current behavior?
Fixes #11645
Currently, if there is a required docker image for an gradeable is
missing, autograding submissions notify both students and instructors in
the autograding results box. However, if multiple images are required
and are missing, the subsequent errors overwrite the details of the
previous error.

### What is the new behavior?
The subsequent errors are appended to a list of errors and looped
through to display each image error.

### Other information?
Current behavior

![before](https://github.com/user-attachments/assets/89ffa3b9-8b5f-4e42-862a-d3859e8d21a8)

New behavior

![after](https://github.com/user-attachments/assets/4a96ea15-6bd1-4a67-a6c7-f72011a82397)

---------

Signed-off-by: Christopher Poon <christopherpoonc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

autograding with multiple docker images missing
3 participants